Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified inference/translate.py to allow batch text translations #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mlinmg
Copy link

@mlinmg mlinmg commented Dec 4, 2023

I have modified inference/translate.py to allow batch text translations to being able to send a list of text requests to batch the processing for better efficency.

…requests to batch the processing for better efficency
@facebook-github-bot
Copy link

Hi @mlinmg!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mlinmg mlinmg changed the title modified inference/translate.py to allow batch text requests modified inference/translate.py to allow batch text translations Dec 4, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2023
ibanesh added a commit that referenced this pull request Dec 8, 2023
kauterry pushed a commit that referenced this pull request Dec 9, 2023
gwenzek pushed a commit that referenced this pull request Jan 18, 2024
@timothepearce
Copy link

Hi @kauterry and @elbayadm, is there a reason this PR is still on hold?

I saw that you closed #187 in favour of this one.

@fjesikfjdskl
Copy link

@mlinmg Hi, your modification to allow batch audio translations is very useful, I would like to allow batch audio translations how should be modified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants