-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build rocm wheels #1081
Build rocm wheels #1081
Conversation
362e98e
to
3752169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but this looks good!
764536e
to
e29cd8c
Compare
e29cd8c
to
0b53f3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Will merge tomorrow when the tests are green
It looks like we need 5-6 hours when there are 7 compile workers. E.g. https://github.com/facebookresearch/xformers/actions/runs/10503375692/job/29096625125 finished in 5h50m. Given there is a 6 hours timeout limit, we should probably increase it. I also see that the wheels skip uploading to s3 |
This PR enables building ROCm xformers wheels, so they can be uploaded along the CUDA xformers wheels
Testing
Observe actions result