Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add PR title linter #333

Merged
merged 1 commit into from
Jan 3, 2024
Merged

chore: Add PR title linter #333

merged 1 commit into from
Jan 3, 2024

Conversation

DaveSkender
Copy link
Member

@LeeDongGeon1996 I've noticed you like to use use Conventional Commit standards for PR titles (merge commits). You've inspired me to add this linter to the Indicator repos. See DaveSkender/Stock.Indicators#1136 for more information on the implementation. I didn't add many constraints, kept it fairly flexible.

@DaveSkender DaveSkender enabled auto-merge (squash) January 3, 2024 01:16
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DaveSkender DaveSkender merged commit 46e7d72 into main Jan 3, 2024
16 checks passed
@DaveSkender DaveSkender deleted the semantic-pr-title branch January 3, 2024 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants