Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deprecation warning on reload() and done() #378

Merged

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented Apr 28, 2024

Description

  • Deprecate reload() and done()
  • No memory saving profit
  • After removing them, it is guranteed that the type of _csdata is always IEnumerable(C#).

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 changed the title feat: Deprecate reload() and done() feat: Add deprecation warning on reload() and done() Apr 28, 2024
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) April 28, 2024 13:04
@LeeDongGeon1996 LeeDongGeon1996 merged commit d89ffc7 into facioquo:main Apr 29, 2024
24 checks passed
@LeeDongGeon1996 LeeDongGeon1996 deleted the feat/remove-reload-done branch May 4, 2024 07:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants