Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update benchmarks #380

Merged

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented May 4, 2024

Description

  • Update benchmarks

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) May 4, 2024 17:27
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to also do one or more of these optional items here too, but otherwise LGTM.

On the .NET project, I'm trying to decide whether to keep the separate docs performance page and just keep the runner (and just link to it in docs) or if there's a better way to simply generate that page. For now, I've been using both.

@LeeDongGeon1996 LeeDongGeon1996 merged commit bd24d59 into facioquo:main May 4, 2024
22 checks passed
@LeeDongGeon1996 LeeDongGeon1996 deleted the test/add-benchmark-v1.3.0 branch May 5, 2024 10:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants