This repository has been archived by the owner on Jul 7, 2018. It is now read-only.
jQuery widget upgrade and #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed reset code to be called outside the plugin Do not force to use textarea for plugin to work Added interface to query points Added excanvas for support from IE6 and later of canvas html element
After the last commit, some options changed and needed to be documented
Forgot to mention the IE6 support
Updated typo in api call on demo.html
- Implemented flexible API layer for extended interaction with the widget state.
New documentation for multi-area and API
|
Implemented multi-area support and added some methods to be used as an API layer for widget state manipulation. This last commit should help you with the issue 8 claiming the functionality of multiple areas. |
|
This looks nice - I will review ASAP. |
Added get set of imageUrl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the plugin to work on IE6 so I first included excanvas polyfill to achieve this but anyway I needed to change the plugin. There were also some things in design/flexibility that I think they limit the potential of the plugin, for example to loose coupling the canvas polygon drawing with a textarea, or to always use a reset button no matter if I want it or not. So I needed to change some of those things and ended up upgrading the plugin to also work with the jquery widget pattern, so it seems that lots of things changed but they really not. Lots of pieces of code you first developed were respected and just changed references or stuff like that to make it fit the jquery widget design pattern. Also I updated the readme file for the new flexible way to call the plugin and its methods or callbacks, and also updated the minified script, and added the excanvas script for the demo to work.