Renderer: Fix bubble chart error type handling

[wirew0rm]

As reported by @protogenes, there was a misstake in the handling of the Error type for BubbleCharts in the ErrorDataSetRender.

fixes #558

[pr-explainer-bot]

Pull Request Report

Changes

1. Fixed the handling of the Error type for BubbleCharts in the ErrorDataSetRenderer class. (commit)

Suggestions

• Line 8: Use && instead of || in the condition localCachedPoints.errorType[DataSet.DIM_X] != ErrorType.NO_ERROR && localCachedPoints.errorType[DataSet.DIM_Y] == ErrorType.NO_ERROR.
• Line 19: Use && instead of || in the condition localCachedPoints.errorType[DataSet.DIM_X] == ErrorType.NO_ERROR && localCachedPoints.errorType[DataSet.DIM_Y] != ErrorType.NO_ERROR.
• Line 30: Use && instead of || in the condition localCachedPoints.errorType[DataSet.DIM_X] != ErrorType.NO_ERROR && localCachedPoints.errorType[DataSet.DIM_Y] != ErrorType.NO_ERROR.

Bugs

• No bugs found.

Improvements

• No improvements found.

Rating

• Readability: 8/10
• Performance: 9/10
• Security: 10/10

Greetings! Great job on the changes made in this pull request. I have reviewed the code and provided some suggestions for improvement. Keep up the good work!

[codecov]

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.01% ⚠️

Comparison is base (7d41fec) 50.28% compared to head (88ac0ed) 50.27%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
- Coverage     50.28%   50.27%   -0.01%     
+ Complexity     6270     6268       -2     
============================================
  Files           375      375              
  Lines         37531    37531              
  Branches       6143     6143              
============================================
- Hits          18871    18869       -2     
  Misses        17414    17414              
- Partials       1246     1248       +2     

Files Changed	Coverage Δ
...acc/chartfx/renderer/spi/ErrorDataSetRenderer.java	79.15% <16.66%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication