Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples: fix non-terminating samples #600

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Samples: fix non-terminating samples #600

merged 4 commits into from
Aug 18, 2023

Commits on Aug 18, 2023

  1. ChartPerformanceMeter: fix no-terminating RunFx call 

    Moved the property updates into the already existing animation timer.
Also fixes the ProfilerInfoBox by adding the meter to a visible node.
    @wirew0rm
    wirew0rm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ec4b859 View commit details
    Browse the repository at this point in the history

  2. Histogram2DimSample: remove non-terminating runFx call

    @wirew0rm
    wirew0rm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b31ad50 View commit details
    Browse the repository at this point in the history

  3. Samples: deamonise background threads

    @wirew0rm
    wirew0rm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    4622932 View commit details
    Browse the repository at this point in the history

  4. WaterfallPerformanceSample: fix termination of sample 

    needed to call the close method on various midi resources.
Still not terminating reliably, but at least it now only blocks
termination if the sample was shown. I guess we can live with that for
now.
    @wirew0rm
    wirew0rm committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cea6e52 View commit details
    Browse the repository at this point in the history