Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made BenchPlugin more extensible to support custom CSS files #623

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Sep 26, 2023

I missed an extension for adding CSS styling to the benchmark chart

@pr-explainer-bot
Copy link

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's the report for you:

Changes

  1. Moved the gridRenderer.setRecorder(recorder); line from line 303 to line 315 in XYChart.java.
  2. Reordered the code block in the setGlobalRecorder(MeasurementRecorder recorder) method in XYChart.java.
  3. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 303 to line 315 in XYChart.java.
  4. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  5. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  6. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  7. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  8. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  9. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  10. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  11. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  12. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  13. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  14. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  15. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  16. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  17. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  18. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  19. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  20. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  21. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  22. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  23. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  24. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  25. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  26. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  27. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  28. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  29. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  30. Moved the benchDrawGrid = recorder.newDuration("xychart-drawGrid"); line from line 315 to line 303 in XYChart.java.
  31. Moved the benchDrawData = recorder.newDuration("xychart-drawData"); line from line 315 to line 303 in XYChart.java.
  32. Moved the `benchDrawGrid = recorder.newDuration("xychart-drawGrid

wirew0rm
wirew0rm previously approved these changes Sep 26, 2023
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (e841751) 48.06% compared to head (d1c960a) 48.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #623      +/-   ##
============================================
- Coverage     48.06%   48.06%   -0.01%     
  Complexity     6203     6203              
============================================
  Files           374      374              
  Lines         38280    38279       -1     
  Branches       6102     6102              
============================================
- Hits          18398    18397       -1     
- Misses        18738    18739       +1     
+ Partials       1144     1143       -1     
Files Coverage Δ
...art/src/main/java/io/fair_acc/chartfx/XYChart.java 58.13% <7.69%> (ø)
.../java/io/fair_acc/chartfx/plugins/BenchPlugin.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wirew0rm wirew0rm merged commit 77a2a8c into main Sep 26, 2023
12 of 14 checks passed
@wirew0rm wirew0rm deleted the ennerf/extend-bench branch September 26, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants