Fix endless update loop in the presence of empty DataSet #674
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Empty DataSet causes some kind of endless update loop somewhere.
To Reproduce
Create chart, add two empty datasets. Wait a second (to let JFX thread do pending tasks). After a second add a point to one of the datasets.
My reproducer in Kotlin
Observed behavior
High CPU and GPU usage, exceptions like
when trying to exit application.
Also endless loop (and the fix) was confirmed by a
println
statement insideupdateAxisRange
function.The problem goes away as soon as a point added to the second empty dataset.
Fix
Suggested simple fix solves the problem.