ChartPlugin scene listener is not removed #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wirew0rm
approved these changes
Sep 30, 2024
|
Thank you for merging and BTW thank you for this great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChartPluginregister a listener on some of its nodesscenePropertybut those listeners are never being removed, even when the plugin is removed from a chart (i.e.chartproperty of the Plugin is set tonull).In some cases, a
ChartPluginthat is not in any chart might still receiveSceneevents, which should not be the case.See
ChartPluginTestin this PR for more details.