follow-up fixes of things not covered by unit-tests/clang

.. also removed verbose stderr printout for an error that is already exported and ignored by the user-code.
fair-acc · Oct 11, 2023 · 391b262 · 391b262
1 parent 6d35466
commit 391b262
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/core/include/gnuradio-4.0/Block.hpp b/core/include/gnuradio-4.0/Block.hpp
@@ -329,7 +329,7 @@ struct Block : protected std::tuple<Arguments...> {
     std::size_t                                                                                                         stride_counter = 0_UZ;
     const std::size_t                                                                                                   unique_id      = _unique_id_counter++;
     const std::string                                                                                                   unique_name = fmt::format("{}#{}", gr::meta::type_name<Derived>(), unique_id);
-    A<std::string, "user-defined name", Doc<"N.B. may not be unique -> ::uniqueName">>                                  name        = gr::meta::type_name<Derived>();
+    A<std::string, "user-defined name", Doc<"N.B. may not be unique -> ::unique_name">>                                 name        = gr::meta::type_name<Derived>();
     A<property_map, "meta-information", Doc<"store non-graph-processing information like UI block position etc.">>      meta_information;
     constexpr static std::string_view                                                                                   description = static_cast<std::string_view>(Description::value);
 

diff --git a/core/include/gnuradio-4.0/settings.hpp b/core/include/gnuradio-4.0/settings.hpp
@@ -385,7 +385,6 @@ class basic_settings : public settings_base {
                 }
                 refl::util::for_each(refl::reflect<TBlock>().members, iterate_over_member);
                 if (!is_set) {
-                    fmt::print(stderr, "The property {} was not set\n", key);
                     ret.insert_or_assign(key, pmtv::pmt(value));
                 }
             }

diff --git a/core/test/plugins/good_conversion_plugin.cpp b/core/test/plugins/good_conversion_plugin.cpp
@@ -27,4 +27,4 @@ ENABLE_REFLECTION_FOR_TEMPLATE(good::convert, in, out);
 // Another is to use the same macro for both single-parametrised
 // and mulciple-parametrised nodes, just to have the parameter
 // packs wrapped in some special type like this:
-GP_PLUGIN_REGISTER_NODE(good::convert, block_parameters<double, float>, block_parameters<float, double>);
+GP_PLUGIN_REGISTER_NODE(good::convert, BlockParameters<double, float>, BlockParameters<float, double>);