-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update restyled to clang-format 18 #132
Conversation
@wirew0rm @ivan-cukic @mormj @willcode @marcusmueller We should nail down the clang-formatting rules sooner rather than later. I initially hoped to have a community-driven, majority-voting process but this may take too much time before GrCon23 and getting this prototype as the new GR 4.0 draft in. If this is a bridge too far, we could postpone this until this repo has been migrated to the gnuradio organisation. Maybe we could do a 2-step mini-workshop going through the clang-formatting rules?
Similarly for the sonar[lint,cube] QA rules (but in another round, since the default is already quite reasonable IMO). At least for my part, I do not want to discuss code formatting, spelling, or nit-picking things in PR reviews while losing track of the bigger picture aspects like architecture design, performance etc. Your input/feedback on this would be much appreciated. |
4dcd796
to
a1cae1b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
@wirew0rm and @drslebedev we should move this to clang-format18 now and settled on a common format. As discussed earlier in #311 we should:
Let's keep the ball rolling and finish this so that we can release a GR 4.0 beta0 version |
49432a3
to
e6ba29a
Compare
Updated to clang-format-18, which has a pending PR for support in restyled restyled-io/restylers#735 which usually are merged pretty quickly. Actual clang-format configuration is a different issue and since there is no agreed upon configuration right now this has no effects since restyled is disabled on this repository. |
Quality Gate passedIssues Measures |
update restyled to use clang-format 18. Fixed on a specific image so there will be no surprise reformatting if clang-format gets it's next release.
Also disable creating pull requests and instead only push the branch and set the status check to decrease the amount of PRs especially for Draft PRs.
Since clang-format is not yet enabled here, we could also wait with merging this until we have finalized the clang-format rules.
Depends on restyled upstream clang-format support: restyled-io/restylers#735