Skip to content

Commit

Permalink
SubscriptionTopic: constrain constructor
Browse files Browse the repository at this point in the history
Constrain the SubscriptionTopic's ctor argument to not allow recursive
calls beating other constructors in overload resolution.

Also update the sonatype github action to the current version to resolve
the java11 warning.
  • Loading branch information
wirew0rm committed Oct 30, 2023
1 parent a610b72 commit be867a6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- name: Install sonar-scanner and build-wrapper
if: matrix.configurations.name == env.REFERENCE_CONFIG && matrix.cmake-build-type == 'Debug'
uses: SonarSource/sonarcloud-github-c-cpp@v1
uses: SonarSource/sonarcloud-github-c-cpp@v2

- name: Configure CMake
if: matrix.configurations.compiler != 'emscripten'
Expand Down
1 change: 1 addition & 0 deletions src/core/include/SubscriptionTopic.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ struct SubscriptionTopic {
SubscriptionTopic() = default;

template<typename PathString>
requires(!std::same_as<SubscriptionTopic, std::remove_cvref_t<PathString>>)
explicit SubscriptionTopic(PathString &&path)
: SubscriptionTopic(""s, std::forward<PathString>(path), {}) {}

Expand Down

0 comments on commit be867a6

Please sign in to comment.