Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDClient: Keep error and RBAC data when handling responses #326

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

frankosterfeld
Copy link
Contributor

Make sure all data (notably the error message) is kept when reading responses.

Make sure all data (notably the error message) is kept when reading
responses.
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (be867a6) 56.01% compared to head (e58208a) 56.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   56.01%   56.09%   +0.08%     
==========================================
  Files          70       70              
  Lines        7404     7402       -2     
  Branches     2726     2723       -3     
==========================================
+ Hits         4147     4152       +5     
+ Misses       1489     1488       -1     
+ Partials     1768     1762       -6     
Files Coverage Δ
src/client/include/Client.hpp 42.69% <63.15%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@RalphSteinhagen RalphSteinhagen merged commit a245ee1 into main Nov 7, 2023
10 of 12 checks passed
@RalphSteinhagen RalphSteinhagen deleted the frank/fix-mdclient-keep-all-frames branch November 7, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants