Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed RxCpp dependency -> obsoleted by GR 4.0 #327

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

RalphSteinhagen
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (be867a6) 56.01% compared to head (c85b313) 55.84%.
Report is 1 commits behind head on main.

❗ Current head c85b313 differs from pull request most recent head 68032c1. Consider uploading reports for the commit 68032c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   56.01%   55.84%   -0.17%     
==========================================
  Files          70       69       -1     
  Lines        7404     7291     -113     
  Branches     2726     2691      -35     
==========================================
- Hits         4147     4072      -75     
+ Misses       1489     1484       -5     
+ Partials     1768     1735      -33     
Files Coverage Δ
src/client/include/Client.hpp 42.69% <63.15%> (+0.32%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, important cleanup to reduce dependencies/build-times/test-failures!

@wirew0rm wirew0rm merged commit c19531d into main Nov 10, 2023
9 of 10 checks passed
@wirew0rm wirew0rm deleted the removeRxCpp branch November 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants