Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cmake options from ENABLE_* to OPENCMW_ENABLE_* #333

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Rename cmake options from ENABLE_* to OPENCMW_ENABLE_* #333

merged 2 commits into from
Dec 5, 2023

Conversation

ivan-cukic
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c19531d) 55.75% compared to head (cc77acb) 55.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   55.75%   55.84%   +0.09%     
==========================================
  Files          69       69              
  Lines        7291     7291              
  Branches     2691     2691              
==========================================
+ Hits         4065     4072       +7     
+ Misses       1489     1484       -5     
+ Partials     1737     1735       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

RalphSteinhagen
RalphSteinhagen approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the specific test enable/disable flag! 👍

@RalphSteinhagen RalphSteinhagen merged commit 99ae7d2 into main Dec 5, 2023
11 of 12 checks passed
@RalphSteinhagen RalphSteinhagen deleted the ivan/rename-cmake-options branch December 5, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-cukic @RalphSteinhagen