Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (client only) support for rda3 #348

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add (client only) support for rda3 #348

wants to merge 12 commits into from

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Jul 5, 2024

This adds support for RDA3, the protocol used by CMW/FESA based devices.

  • Fixes some quirks in the cmwlight serialiser that are needed to serialize the control messages:
    • support for maps
    • deserialise empty objects/maps
    • some minor bugs
    • add unittests with real world data to prevent regressions
  • Adds a lightweight zeromq STREAM based nameserver client to resolve rda3 device names
  • Add a cmwlight client implementation

There are still some open points, for now only get requests are handled completely, subscriptions generally work but need a bit more state-tracking to be reliable

  • finish the state machine
  • replace some fixed strings with the actual data (e.g. client information)
  • integrate the name server into the client.
  • general code cleanup

wirew0rm and others added 8 commits July 8, 2024 23:03
@wirew0rm
Implementation of rda3 Directory Client
d8c6773 
Implemented using the ZMQ NATIVE pattern s.t. it can use the same
pollers and zmq context as the client itself.

Signed-off-by: Alexander Krimm <[email protected]>
Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
CMWLightSerialiser: enable support for std::map and nesting
0a306cd 
Support for nested Datastructures was not implemented correctly before
because only serialise + deserialise was checked but not the actual
serialised output.

Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
Add parsing rda3 data into a map
1b4d683 
Also allows fieldnames with starting with a numeric value by prefixing
them with ' x_'.

Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
CmwLightSerialiser: fix handling of empty nested objects/maps
1174655 
Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
WIP implementation of cmwlight client
2eb0f5a 
Signed-off-by: Alexander Krimm <[email protected]>
@restyled-commits @wirew0rm
Restyled by clang-format
e3897b9 
Signed-off-by: Alexander Krimm <[email protected]>
@restyled-commits @wirew0rm
Restyled by cmake-format
7efc9fa 
Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
fix warinings
608c594 
Signed-off-by: Alexander Krimm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wirew0rm @restyled-commits