Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frank/upgrade gp #176

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Frank/upgrade gp #176

merged 12 commits into from
Apr 8, 2024

Conversation

frankosterfeld
Copy link
Contributor

Make opendigitizer work with latest graph-prototype.

@frankosterfeld
WIP start porting UI
87d22a6 
some code in #if 0 needs porting.
@frankosterfeld
Enable fPIC before building FMT
b38ffba 
opencmw-cpp pulls in fmt, and builds it without fPIC otherwise, which
then fails when linking GP plugins.
@frankosterfeld
qa_GnuRadioWorker: do not crash when no data received
08e3740
@frankosterfeld
Minor GR worker improvements
41a5af1
@frankosterfeld
Use much bigger timeout of 10s (needed for coverage)
4c63a39 
The GRC parsing/graph creation for the 6 blocks in the "Streaming"
test takes 6 seconds alone here, so use much bigger timeouts.
To be investigating why it's _that_ slow under coverage.
@frankosterfeld frankosterfeld marked this pull request as ready for review April 8, 2024 12:16
RalphSteinhagen
RalphSteinhagen approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Will merge this as soon as the CI passes.

@frankosterfeld frankosterfeld merged commit 26a4cd8 into main Apr 8, 2024
9 checks passed
@frankosterfeld frankosterfeld deleted the frank/upgrade-gp branch April 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankosterfeld @RalphSteinhagen @restyled-commits