Fix demo dashboard to show FFT magnitude plot. #198
Merged
+68
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drslebedev <[email protected]>
wirew0rm
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Very nicely identified the issues and found workarounds to quickly make the demonstration usable again. The proper fixes will be possible once the flowgraph part is rewritten to use the new gr4 message based flowgraph API.
Can be merged once the CI has passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all block data types are set to
float, and there is currently no option to configure this in the YAML file. Additionally, OpenDigitizer uses custom registry implementations, which will be addressed in the next PR.As a workaround for the
DataSet, you can create two independent blocks: one forfloatanddouble, and another forDataSet<float>andDataSet<double>.