Fix #747: Python Request mistakenly identified as Meta Quest

faisalman · Sep 20, 2024 · 391b808 · 391b808
1 parent 3de1961
commit 391b808
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js
@@ -761,7 +761,7 @@
             ], [MODEL, [VENDOR, GOOGLE], [TYPE, XR]], [
             /(pico) (4|neo3(?: link|pro)?)/i                                    // Pico
             ], [VENDOR, MODEL, [TYPE, XR]], [
-            /(quest( \d| pro)?)/i                                               // Oculus Quest
+            /; (quest( \d| pro)?)/i                                             // Oculus Quest
             ], [MODEL, [VENDOR, FACEBOOK], [TYPE, XR]], [
 
             ///////////////////

diff --git a/test/specs/device-all.json b/test/specs/device-all.json
@@ -1484,6 +1484,15 @@
             "type": "xr"
         }
     },
+    {
+        "desc": "Issue #747",
+        "ua": "python-requests/2.25.1",
+        "expect": {
+            "vendor": "undefined",
+            "model": "undefined",
+            "type": "undefined"
+        }
+    },
     {
         "desc": "OnePlus One",
         "ua": "Mozilla/5.0 (Linux; Android 4.4.4; A0001 Build/KTU84Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.59 Mobile Safari/537.36",