Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for honor separated from Huawei #749

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Julias0
Copy link

@Julias0 Julias0 commented Sep 24, 2024

Prerequisites

Type of Change

Enhancement - related to #704

Description

Huawei and Honor were assumed to be the same company from the useragent. But honor has now separated into a separate organization, so its parsing needs to be separated off from huawei

Test

All existing test cases have passed, some test cases which earlier gave huawei now give honor

Impact

Some devices which earlier were marked as huawei will now get marked as honor. This can be considered a change since the output of the parser is different for the same set of data

Other Info

Copy link
Owner

@faisalman faisalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you change the commit to include only the relevant changes: ua-parser.js, device-all.json, and ua-parser-enum.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants