Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: name eslint config groups for inspection #3249

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 4, 2024

Adds names to the eslint config groups to make them easier to distinguish when inspecting them.

pnpm eslint --inspect-config --flag unstable_ts_config
UI-Diff
Before After
{443AD051-A6D4-40F0-86DF-345A12402C4C} grafik

The two remaining sections are from eslint/recommended and prettier/recommended.
I'll create PRs there as well to populate the names.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 4, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 4, 2024
@ST-DDT ST-DDT requested review from a team November 4, 2024 15:05
@ST-DDT ST-DDT self-assigned this Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9825613
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672a0d7d6ca030000854b783
😎 Deploy Preview https://deploy-preview-3249.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (ae10d9a) to head (9825613).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3249   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2805     2805           
  Lines      217098   217098           
  Branches      968      970    +2     
=======================================
+ Hits       217018   217027    +9     
+ Misses         80       71    -9     

see 2 files with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 4, 2024

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 😲

@ST-DDT ST-DDT requested a review from a team November 4, 2024 16:38
@ST-DDT ST-DDT enabled auto-merge (squash) November 5, 2024 12:13
@ST-DDT ST-DDT merged commit df87d60 into next Nov 5, 2024
23 checks passed
@ST-DDT ST-DDT deleted the eslint/config-group-names branch November 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants