refactor(image): deprecate urlPlaceholder #3341
Open
+38
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3341 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2811 2811
Lines 217006 217012 +6
Branches 939 936 -3
==========================================
+ Hits 216955 216959 +4
- Misses 51 53 +2
|
import-brain
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our integration test and some manual tests, I determined, that
faker.image.urlPlaceholderis no longer working most of the time.So we should deprecate it for removal.
https://github.com/faker-js/faker/actions/runs/12460490305/job/34778781065
https://via.placeholder.com/1000x1000
https://via.placeholder.com/3501x3500/922c3c/c30a74.jpeg?text=vulnus%20cuius%20veritas
There seems to be additional size constrictions e.g. 3999 -> 3500.