Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark:all_methods task by excluding Faker::Deprecator module from benchmark target #2988

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

amatsuda
Copy link
Contributor

@amatsuda amatsuda commented Aug 8, 2024

Motivation / Background

I found that the benchmark task rake benchmark:all_methods is not working on current main branch.

So here's a patch that makes the task runnable again.

Additional information

The task has been broken since f586da7 that added a new module named Faker::Deprecator. And this patch just adds it to the ignore module list.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature. => Actually, no. But the tasks that used not to work are now working.
  • Tests and Rubocop are passing before submitting your proposed changes.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koic koic merged commit 9dfc3a3 into faker-ruby:main Aug 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants