da-DK license plates #3010
Open
da-DK license plates #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,4 +60,8 @@ def test_da_dk_counrty_code | |||
| assert_match(/(\+45)[\s](\d\d[\s-]?){4}$/, Faker::PhoneNumber.phone_number_with_country_code) | |||
| assert_match(/(\+45)[\s](\d\d[\s-]?){4}$/, Faker::PhoneNumber.cell_phone_with_country_code) | |||
| end | |||
|
|
|||
| def test_da_dk_license_plate | |||
| assert_match(/^(O[A-HJ-NPR-Z](?![BHBUCCCDDKDUEUKZMUYPSSUDUNVC])|[A-HJ-NPR-Z]{2})(\d{2,5})$/, Faker::Vehicle.license_plate) | |||
There was a problem hiding this comment.
This looks too convoluted. What do you think of taking doing something like this:
There was a problem hiding this comment.
I agree that it is convoluted, but I think your suggestion got cut off - unless you want to really simplify it 🙂
There was a problem hiding this comment.
Uh, my bad! Changing computers mess up with my keyboard shortcuts 🙈
I meant something like:
assert_match(/^[A-Z]{2}-[0-9]{5}/, Faker::Vehicle.license_plate)
|
Could you also add screenshots of using this in the console ( |
Co-authored-by: Stefanni Brasil <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because it was not possible to generate valid Danish license plates. It adds the simplest possible license plates consisting of 2 letters and 5 digits. It follows the rules laid out on the Danish Wikipedia.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: