-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dist): remove setup.cfg
#2277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2277 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7506 7506
Branches 1277 1277
=========================================
Hits 7506 7506 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Left a couple of comments
Remove
setup.cfg
altogheter, and consolidate most of the things insidepyproject.toml
.Bring back logotypes into⬅️ Already inREADME.rst
, stop using raw HTML there.master
, preview can be found here: https://test.pypi.org/project/falcon/4.0.0.dev2/.One consequence of this change is that we are completely dropping support for the
python setup.py test
command, but so do the newest versions ofsetuptools
.Closes: #2314.