-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated methods, attributes and classes #2282
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7604 7507 -97
Branches 1285 1238 -47
=========================================
- Hits 7604 7507 -97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a suggestion about the docs
Closes #1853.
@maxking:
Note that the proposed removal of support for positional arguments inHTTPUnauthorized
breaks Mailman.I have opened MR #1267 on Mailman's side, let's see if it can get merged soon. Otherwise maybe we can make an undocumented exception forHTTPUnauthorized
?The MR has been merged on Mailman's side. All clear 👍