Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (status_codes): add new status codes #2328

Merged
merged 13 commits into from
Sep 15, 2024
Merged

Conversation

aarcex3
Copy link
Contributor

@aarcex3 aarcex3 commented Sep 12, 2024

Summary of Changes

Added new status codes to conform to RFC 9110.

Related Issues

#2276

Pull Request Checklist

  • Coding style is consistent with the rest of the framework.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4567c97) to head (f799aa8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7502      7522   +20     
  Branches      1275      1275           
=========================================
+ Hits          7502      7522   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @aarcex3!

We cannot close #2276 yet, because you only added new codes, but haven't synced any of the existing ones. However, I can see there already exists #2330 by @prathik2401 out there that continues on the same topic, so I guess we can merge this one as a standalone increment.

We'll just need to remember to write a newsfragment as part of @2330.

@vytas7 vytas7 merged commit 87e0454 into falconry:master Sep 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants