Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add mTLS certificate loading for Falco via Helm #549

Closed

Conversation

jgmartinez
Copy link
Contributor

What type of PR is this?

/kind feature

/kind chart-release

Any specific area of the project related to this PR?

/area falco-chart

What this PR does / why we need it:

This PR adds the capability of loading certificates for mTLS communication dynamically via Helm values. It's structured in a way to make it easier to deploy mTLS cryptographic material for Falco http_output when mTLS is enabled.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Split of #546.

Checklist

  • Variables are documented in the README.md

@poiana poiana added dco-signoff: yes kind/feature New feature or request kind/chart-release Add this label when the chart version has been bumped area/falco-chart labels Oct 16, 2023
@poiana poiana requested review from alacuku and bencer October 16, 2023 12:33
@poiana
Copy link
Contributor

poiana commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgmartinez
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif
Copy link
Member

Issif commented Oct 17, 2023

Can you rebase on the master and update the changelog.md and readme.md please

@jgmartinez jgmartinez force-pushed the feature/falcomtlscertload branch from 3fcbf4f to a1fc3de Compare October 18, 2023 07:44
@poiana poiana added size/L and removed size/M labels Oct 18, 2023
@jgmartinez
Copy link
Contributor Author

Can you rebase on the master and update the changelog.md and readme.md please

Done :)

@cpanato
Copy link
Member

cpanato commented Oct 19, 2023

@jgmartinez sorry but you will need to rebase again, we did some refactor in the ci system and where we store the charts

@jgmartinez jgmartinez force-pushed the feature/falcomtlscertload branch from 519bb0a to b72b1a8 Compare October 20, 2023 11:47
@poiana poiana added size/M and removed size/L labels Oct 20, 2023
@poiana poiana added size/L and removed size/M labels Oct 20, 2023
@jgmartinez
Copy link
Contributor Author

Done @cpanato

* add service_monitor + prometheus_rules
* fix error with alertmanager custom map and threshold

Signed-off-by: Thomas Labarussias <[email protected]>
Issif and others added 3 commits October 23, 2023 11:18
@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • a53877c Revert "Bumped Chart version and added Changelog"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jgmartinez
Copy link
Contributor Author

Reopened at #565

@jgmartinez jgmartinez closed this Oct 23, 2023
@jgmartinez jgmartinez deleted the feature/falcomtlscertload branch November 1, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falco-chart dco-signoff: no kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants