-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add mTLS certificate loading for Falco via Helm #549
Feature: Add mTLS certificate loading for Falco via Helm #549
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jgmartinez The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you rebase on the master and update the changelog.md and readme.md please |
3fcbf4f
to
a1fc3de
Compare
Done :) |
@jgmartinez sorry but you will need to rebase again, we did some refactor in the ci system and where we store the charts |
Signed-off-by: Juan Gonzalez Martinez <[email protected]>
Signed-off-by: Juan Gonzalez Martinez <[email protected]>
519bb0a
to
b72b1a8
Compare
Signed-off-by: Juan Gonzalez <[email protected]>
Done @cpanato |
* add service_monitor + prometheus_rules * fix error with alertmanager custom map and threshold Signed-off-by: Thomas Labarussias <[email protected]>
Signed-off-by: Thomas Labarussias <[email protected]>
This reverts commit 517b84f.
Signed-off-by: Juan Gonzalez <[email protected]>
e63a9be
to
38b2ca3
Compare
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Reopened at #565 |
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
This PR adds the capability of loading certificates for mTLS communication dynamically via Helm values. It's structured in a way to make it easier to deploy mTLS cryptographic material for Falco http_output when mTLS is enabled.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Split of #546.
Checklist