Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Falco 0.37.0] cleanup(falco): remove --userspace flag #595

Closed

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area falco-chart

What this PR does / why we need it:

This PR removes the --userspace flag from Falco helm chart

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Andreagit97
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/S label Dec 22, 2023
@Andreagit97
Copy link
Member Author

This PR is just to remind us that we need to remove the --userspace flag before releasing the helm chart, because it doesn't exist anymore. This PR will fail until we bump the Falco version in the helm chart since the new engine.kind config is supported only in Falco 0.37.0.

Some side notes:

  • do we still need the --disable-source flag, now that we have kind.engine = none
  • do we really need the block driver in the helm chart .yaml? why not use the new Falco config?

@Andreagit97
Copy link
Member Author

do we really need the block driver in the helm chart .yaml? why not use the new Falco config?

In the end yes we need to keep it, because there are leastPrivileged and hostNetwork fields that are only inherent to the deployment of Falco

@Andreagit97
Copy link
Member Author

done in #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants