Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana-dashboard: add support grafana crd #596

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

batazor
Copy link
Contributor

@batazor batazor commented Dec 24, 2023

What type of PR is this?

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

/area falco-exporter-chart

What this PR does / why we need it:

Support annotation for grafana

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: yes labels Dec 24, 2023
@poiana
Copy link
Contributor

poiana commented Dec 24, 2023

Welcome @batazor! It looks like this is your first PR to falcosecurity/charts 🎉

@batazor
Copy link
Contributor Author

batazor commented Jan 21, 2024

@alacuku can you check this PR?

@cpanato
Copy link
Member

cpanato commented Jan 22, 2024

can you please sign the dco? thanks for this PR

Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Jan 25, 2024

LGTM label has been added.

Git tree hash: 385ca079d098caf913eeec616f6c96ce7b911af3

@poiana
Copy link
Contributor

poiana commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, batazor, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 487b6c6 into falcosecurity:master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants