Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release.md): fix release process workflows explanation #745

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Sep 24, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

This PR fixes the description of the workflows in the release process process documentation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes labels Sep 24, 2024
@poiana poiana requested review from alacuku and bencer September 24, 2024 08:17
@poiana
Copy link
Contributor

poiana commented Sep 24, 2024

Welcome @ekoops! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/XS label Sep 24, 2024
@ekoops ekoops changed the title fix(release.md): fix release process workflows explanation wip: fix(release.md): fix release process workflows explanation Sep 24, 2024
@ekoops ekoops changed the title wip: fix(release.md): fix release process workflows explanation fix(release.md): fix release process workflows explanation Sep 24, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ekoops

I know this is not strictly related to your PR. Can you please fix these two links reported by the linter?

🙏

Errors in charts/falco/README.gotmpl
[404] https://falco.org/docs/getting-started/third-party/learning/#falco-with-multiple-sources | Cached: Error (cached)
Errors in charts/falco/README.md
[404] https://falco.org/docs/getting-started/third-party/learning/#falco-with-multiple-sources | Failed: Network error: Not Found

@ekoops ekoops requested a review from leogr October 8, 2024 15:38
@ekoops
Copy link
Contributor Author

ekoops commented Oct 8, 2024

I think they went away with my rebase.... Let's see.

@poiana poiana added the lgtm label Oct 8, 2024
@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

LGTM label has been added.

Git tree hash: 9925c848231dd1227f8dee6d7dfdb1e0d19c6ef0

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 8, 2024
@poiana poiana merged commit 5f318e1 into falcosecurity:master Oct 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants