-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated project deps. #286
Conversation
Fixed build. Signed-off-by: Federico Di Pierro <[email protected]>
/cc @dwindsor |
/hold |
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
…I version. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
@@ -2,11 +2,11 @@ version: 2.1 | |||
jobs: | |||
"build-test": | |||
docker: | |||
- image: alpine:3.16 | |||
- image: alpine:3.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped the image to get go 1.20.
@@ -169,7 +169,7 @@ jobs: | |||
fi | |||
"release": | |||
docker: | |||
- image: cimg/go:1.18 | |||
- image: cimg/go:1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use go1.20 now!
@@ -5,5 +5,6 @@ | |||
{{ .Commands }} | |||
|
|||
{{ .Flags }} | |||
-v, --version version for driverkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was perhaps added by new version of viper?
@@ -1,147 +1,142 @@ | |||
module github.com/falcosecurity/driverkit | |||
|
|||
go 1.18 | |||
go 1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did i tell you we bumped to go 1.20?
@@ -110,6 +108,7 @@ func (bp *DockerBuildProcessor) Start(b *builder.Build) error { | |||
if err != nil { | |||
return err | |||
} | |||
cli.NegotiateAPIVersion(context.Background()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, we can now negotiate Client API version against the server one, so that the client version is greater than server version, client can negotiate a lower operating version to satisfy server needs.
/cc @dwindsor @EXONER4TED |
Part of the effort around: falcosecurity/evolution#305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EXONER4TED, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Ran
go get -u
andgo mod tidy
.Also, had to bump golang to 1.20.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: