Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated project deps. #286

Merged
merged 6 commits into from
Sep 1, 2023
Merged

chore: updated project deps. #286

merged 6 commits into from
Sep 1, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 28, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Ran go get -u and go mod tidy.
Also, had to bump golang to 1.20.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Fixed build.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 28, 2023

/cc @dwindsor

leogr
leogr previously approved these changes Aug 28, 2023
@leogr
Copy link
Member

leogr commented Aug 28, 2023

/hold

Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP changed the title chore: updated project deps. wip: chore: updated project deps. Aug 28, 2023
@FedeDP FedeDP changed the title wip: chore: updated project deps. chore: updated project deps. Aug 29, 2023
@@ -2,11 +2,11 @@ version: 2.1
jobs:
"build-test":
docker:
- image: alpine:3.16
- image: alpine:3.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped the image to get go 1.20.

@@ -169,7 +169,7 @@ jobs:
fi
"release":
docker:
- image: cimg/go:1.18
- image: cimg/go:1.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use go1.20 now!

@@ -5,5 +5,6 @@
{{ .Commands }}

{{ .Flags }}
-v, --version version for driverkit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was perhaps added by new version of viper?

@@ -1,147 +1,142 @@
module github.com/falcosecurity/driverkit

go 1.18
go 1.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did i tell you we bumped to go 1.20?

@@ -110,6 +108,7 @@ func (bp *DockerBuildProcessor) Start(b *builder.Build) error {
if err != nil {
return err
}
cli.NegotiateAPIVersion(context.Background())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, we can now negotiate Client API version against the server one, so that the client version is greater than server version, client can negotiate a lower operating version to satisfy server needs.

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2023

/cc @dwindsor @EXONER4TED

@poiana poiana requested a review from EXONER4TED August 29, 2023 08:20
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2023

Part of the effort around: falcosecurity/evolution#305

Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

/approve

@poiana
Copy link

poiana commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 1, 2023

/unhold

@poiana poiana merged commit c00878e into master Sep 1, 2023
@poiana poiana deleted the cleanup/update_deps branch September 1, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants