Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(cmd): require kernelrelease and kernelversion from user in local command. #307

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 30, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area cmd

What this PR does / why we need it:

Require kernelrelease and eventually kernelversion to be passed by user instead of using unix. This allows driverkit to be portable (eg: building on windows).
Useful to fix falcosecurity/falcoctl#356 since falcoctl is built for windows and osx too and its deps must be portable.

It is a small UX worsening but since all driverkit commands already require kernelrelease, i think it is safe to do so for local too.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 30, 2023

/cc @dwindsor 🚀

@FedeDP FedeDP changed the title cleanup(cmd): require kernelrelease and kernelversion in local command. cleanup(cmd): require kernelrelease and kernelversion from user in local command. Nov 30, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 1, 2023

Most probably, as next step for the local builder, i would love to introduce back the capability to receive --kernelurls parameter and download them.
Here the hardest part would be to correctly extract and manage them since kernel headers packages can have different format on different distros and we have a single local builder template.
I think that the local builder processor can download kernelurls packages for us; then we might want to use eg: https://github.com/mholt/archiver to extract the kernel headers packages, no matters the format.

Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 53a49ea into master Dec 1, 2023
4 checks passed
@poiana poiana deleted the chore/require_kernel_release_version_local branch December 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants