new(docker): add cmake and git packages to builders images.
#309
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
poiana
added
dco-signoff: yes
kind/feature
| git | ||
|
|
||
| # Install cmake3.x (on centos7 `cmake` package installs cmake2.x) | ||
| RUN curl -L -o /tmp/cmake.tar.gz https://github.com/Kitware/CMake/releases/download/v3.22.5/cmake-3.22.5-linux-$(uname -m).tar.gz; \ |
There was a problem hiding this comment.
We need to manually install a cmake 3.x on centos:7.
| @@ -39,8 +39,10 @@ RUN apt-get update \ | |||
| software-properties-common \ | |||
| gpg \ | |||
| zstd \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
| cmake \ | |||
| git \ | |||
There was a problem hiding this comment.
We need git too.
We will run cmake configuration step in full mode, even if with lots of things disabled. Unfortunately, given that libs only recently gained the ability to build the bpf probe in MINIMAL_BUILD mode, we need to configure the project in full mode, and this requires git because grpc and protobuf deps need to be fetched/cloned.
|
/cc @EXONER4TED /hold because it is friday :) |
|
Looks good to me, but I am fine with the hold because it is Friday 😅 |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EXONER4TED, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Split from #302 ; add cmake and git packages to builder images.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: