Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abandoned: Add initial support for Peribolos #191

Closed
wants to merge 402 commits into from
Closed

abandoned: Add initial support for Peribolos #191

wants to merge 402 commits into from

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Sep 6, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area utils

What this PR does / why we need it:

As the evolution repository is now the central point for the evolution of the project, and as the falcosecurity organization is formed by the community, and as the point of contact of the contributions are in git (Github), is correct that the source of truth as a declarative configuration of the Github organization is put here.

Moreover, this PR adds the Prow job needed for the automation that reconciles the desired source of truth with the actual one.

Which issue(s) this PR fixes:

None (abandoned)

Special notes for your reviewer:

cc @falcosecurity/test-infra-maintainers @falcosecurity/evolution-maintainers

@poiana
Copy link
Contributor

poiana commented Sep 6, 2022

@maxgio92: The label(s) area/utils cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area utils

What this PR does / why we need it:

As the evolution repository is now the central point for the evolution of the project, and as the falcosecurity organization is formed by the community, and as the point of contact of the contributions are in git (Github), is correct that the source of truth as a declarative configuration of the Github organization is put here.

Moreover, this PR adds the Prow job needed for the automation that reconciles the desired source of truth with the actual one.

Which issue(s) this PR fixes:

Fixes #176

Special notes for your reviewer:

cc @falcosecurity/test-infra-maintainers @falcosecurity/evolution-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxgio92 maxgio92 changed the title wip: Add initial support for peribolos jobs wip: Add initial support for Peribolos Sep 6, 2022
@maxgio92
Copy link
Member Author

maxgio92 commented Sep 6, 2022

To make this PR take effect, we need falcosecurity/test-infra#841 in place.

@leogr
Copy link
Member

leogr commented Sep 6, 2022

Hey @maxgio92

This is great. I'd just put org.yaml in a different folder. What do you think about org/org.yaml or falcosecurity/org.yaml ?

jasondellaluce and others added 23 commits September 8, 2022 10:14
This change is a simple editorial one due to the updated link,
and as such does not require any votation.

Signed-off-by: Jason Dellaluce <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
In English, both sentences have the same meaning:
 - Maintainers can be added or moved to or from Emeritus Maintainers with a majority vote.
 - Maintainers can be added (or moved to or from Emeritus Maintainers) with a majority vote.

However, the latter is preferable because it explicitly clarifies that a majority vote is required to add a maintainer.

Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
@maxgio92 maxgio92 closed this Sep 8, 2022
@poiana poiana added size/S and removed size/XXL labels Sep 8, 2022
@maxgio92 maxgio92 changed the title wip: Add initial support for Peribolos abandoned: Add initial support for Peribolos Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.