chore: add new Prometheus endpoint information #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain how to activate the /metrics endpoint and what it will return. Signed-off-by: Samuel Gaist <[email protected]>
|
Awesome, I'll update the existing output fields for metrics (since we also added new ones) in a follow up PR @leogr as well. |
incertum
reviewed
May 16, 2024
incertum
reviewed
May 16, 2024
Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Samuel Gaist <[email protected]>
Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Samuel Gaist <[email protected]>
|
Thank you for this! It's really useful |
|
/hold until 0.38.0 release /milestone falco-0.38.0 |
incertum
reviewed
May 22, 2024
There was a problem hiding this comment.
@sgaist and @LucaGuerra @leogr this PR should be merged first, after that I can rebase the second PR #1325.
Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Samuel Gaist <[email protected]>
…d be present Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Samuel Gaist <[email protected]>
Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Samuel Gaist <[email protected]>
|
/assign |
LucaGuerra
approved these changes
May 30, 2024
|
LGTM label has been added. Git tree hash: da5a7eab920e59fbb077336a4e142d16dfe08a4b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Explain how to activate the /metrics endpoint and what it will return.
Which issue(s) this PR fixes:
Fixes #1291
Special notes for your reviewer: