chore(ci): build Falco in RelWithDebInfo, and upload Falco debug symbols as github artifacts #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ols as github artifacts. Then, upload these artifacts as release assets. Signed-off-by: Federico Di Pierro <[email protected]>
|
/milestone 0.40.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ok PR tested:
Also: |
|
Also, thanks to @shane-lawrence for the |
LucaGuerra
reviewed
Jan 16, 2025
Signed-off-by: Federico Di Pierro <[email protected]>
LucaGuerra
approved these changes
Jan 16, 2025
leogr
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
#3440 allows us to build Falco in RelWithDebInfo target.
Use the new target and upload the debug symbols as github artifacts.
Then, as part of the release CI, use these artifacts and upload them as github assets.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: