chore(pkg/driver): address some review concerns.

Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Aldo Lacuku <[email protected]>
falcosecurity · Dec 4, 2023 · 62d9da1 · 62d9da1
1 parent d594814
commit 62d9da1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/pkg/driver/distro/debian_test.go b/pkg/driver/distro/debian_test.go
@@ -92,37 +92,50 @@ func TestDistroDebianFixup(t *testing.T) {
 		krInput    string
 		kvInput    string
 		krExpected string
+		kvExpected string
 	}
 	testCases := []testCase{
 		{
 			// Substitution needed since kernelversion contains the real kernelrelease (-rt)
 			krInput:    "5.10.0-0.deb10.22-rt-amd64",
 			kvInput:    "#1 SMP PREEMPT_DYNAMIC Debian 5.10.178-3",
 			krExpected: "5.10.178-3-rt-amd64",
+			kvExpected: "1",
 		},
 		{
-			// Substitution needed since kernelversion contains the real kernelrelease (-cloud)
-			krInput:    "6.1.0-13-cloud-amd64",
+			// Substitution needed since kernelversion contains the real kernelrelease (generic flavor)
+			krInput:    "6.1.0-13-amd64",
 			kvInput:    "#1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29)",
-			krExpected: "6.1.55-1-cloud-amd64",
+			krExpected: "6.1.55-1-amd64",
+			kvExpected: "1",
 		},
 		{
 			// Substitution NOT needed
 			krInput:    "5.10.0-0.deb10.22-amd64",
 			kvInput:    "#1 SMP PREEMPT_DYNAMIC",
 			krExpected: "5.10.0-0.deb10.22-amd64",
+			kvExpected: "1",
 		},
 		{
-			// Substitution NOT needed
+			// Substitution NOT needed; kernelversion is 39
 			krInput:    "5.10.0-0",
-			kvInput:    "#1 SMP PREEMPT_DYNAMIC",
+			kvInput:    "#39 SMP PREEMPT_DYNAMIC",
 			krExpected: "5.10.0-0",
+			kvExpected: "39",
 		},
 		{
 			// Substitution NOT needed
 			krInput:    "6.5.3-1~bpo12+1-rt-amd64",
 			kvInput:    "#1 SMP PREEMPT_DYNAMIC",
 			krExpected: "6.5.3-1~bpo12+1-rt-amd64",
+			kvExpected: "1",
+		},
+		{
+			// Substitution NOT needed
+			krInput:    "6.5.3-1~bpo12+1-rt-amd64",
+			kvInput:    "malformed",
+			krExpected: "6.5.3-1~bpo12+1-rt-amd64",
+			kvExpected: "malformed",
 		},
 	}
 	for _, tCase := range testCases {
@@ -131,5 +144,6 @@ func TestDistroDebianFixup(t *testing.T) {
 		kr.KernelVersion = tCase.kvInput
 		fixedKr := deb.FixupKernel(kr)
 		assert.Equal(t, tCase.krExpected, fixedKr.String())
+		assert.Equal(t, tCase.kvExpected, fixedKr.KernelVersion)
 	}
 }
diff --git a/pkg/driver/distro/generic.go b/pkg/driver/distro/generic.go
@@ -44,7 +44,7 @@ func (g *generic) String() string {
 //nolint:gocritic // the method shall not be able to modify kr
 func (g *generic) FixupKernel(kr kernelrelease.KernelRelease) kernelrelease.KernelRelease {
 	// Take eg: "#1 SMP PREEMPT_DYNAMIC Tue, 10 Oct 2023 21:10:21 +0000" and return "1".
-	kv := strings.Trim(kr.KernelVersion, "#")
+	kv := strings.TrimLeft(kr.KernelVersion, "#")
 	kv = strings.Split(kv, " ")[0]
 	kr.KernelVersion = kv
 	return kr