fix(cmd/info): handle "context canceled" errors #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/fix-artifact-info-cancelation
branch
from
c2473c3
to
156a652
Compare
The command should exit when the context is canceled by a termination signal. In such case the command prints the reason why it exited. Furthermore, the table header is printed to stdout only when data is found for the artifacts. Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/fix-artifact-info-cancelation
branch
from
156a652
to
435a231
Compare
Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/fix-artifact-info-cancelation
branch
from
435a231
to
69e39f4
Compare
leogr
approved these changes
Aug 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 41ae20d7ff9813750bb50b0755d7d46db9f399ab
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
The command should exit when the context is canceled by a termination signal. In such a case, the command prints the reason why it exited.
Furthermore, the table header is printed to stdout only when data is found for the artifacts.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: