Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugpatching issue 344 vulnerabilities including GHSA-m425-mq94-257g #346

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

cschp
Copy link
Contributor

@cschp cschp commented Nov 8, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it: upgrades alpine in dockerfile from 3.18.3 to 3.18.4 to patch a go vulnerability then upgrades and patches libssl3 and libcrypto3

Which issue(s) this PR fixes:344

Fixes #344

Special notes for your reviewer: please let me know if i messed up formatting somewhere as this is my first pr here

@poiana
Copy link
Contributor

poiana commented Nov 8, 2023

Welcome @cschp! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@poiana poiana added the size/XS label Nov 8, 2023
@leogr
Copy link
Member

leogr commented Nov 9, 2023

@LucaGuerra PTAL

@LucaGuerra
Copy link
Contributor

@leogr LGTM!

@cschp
Copy link
Contributor Author

cschp commented Nov 10, 2023

@leogr @LucaGuerra who do i need lgtm from to merge?

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 10, 2023

LGTM label has been added.

Git tree hash: bddf8f4db4b3a937eb9f192f26f7766aff2223b9

@poiana
Copy link
Contributor

poiana commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cschp, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cdccbeb into falcosecurity:main Nov 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

patching go vulnerability GHSA-m425-mq94-257g
5 participants