Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd/driver): add preview to all driver related commands. #363

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 1, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind documentation

Any specific area of the project related to this PR?

/area cli

What this PR does / why we need it:

Since all the driver related commands might change in the future, add a preview notice to all of them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Thank you!

@poiana
Copy link
Contributor

poiana commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 313f047 into main Dec 4, 2023
14 checks passed
@poiana poiana deleted the chore/add_preview_driver branch December 4, 2023 11:16
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 5, 2023

/milestone v0.7.0

@poiana poiana added this to the v0.7.0 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants