Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs/otel_metrics): add OTEL metrics output support #1012

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ekoops
Copy link

@ekoops ekoops commented Oct 2, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

area outputs

/area tests

What this PR does / why we need it:

This PR adds support to generate OTEL metrics and export them through OTLP. It also updates the labels syntax in Dockerfile to the newer one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added kind/feature New feature or request dco-signoff: yes labels Oct 2, 2024
@poiana
Copy link

poiana commented Oct 2, 2024

Welcome @ekoops! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana
Copy link

poiana commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ekoops
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you fix the lint issues thanks

handlers.go Outdated Show resolved Hide resolved
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also push metrics about the matches, can you do like for the prom metrics, and set up metrics for the outputs and inputs please

outputs/otlp_metrics.go Outdated Show resolved Hide resolved
outputs/otlp_metrics.go Outdated Show resolved Hide resolved
outputs/otlp_metrics.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants