Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): do not derefence nil pointer #103

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jun 4, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area broker

/area protocol-buffers

/grafana-dashboard

/area collectors

/area tests

/area examples

What this PR does / why we need it:

Before checking if an owner reference is set as controller we check that the field is not nil before dereferencing it.

Which issue(s) this PR fixes:
#102

Fixes #
#102
Special notes for your reviewer:

Before checking if an owner reference is set as controller we check
that the field is not nil before dereferencing it.

Signed-off-by: Aldo Lacuku <[email protected]>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes labels Jun 4, 2024
@poiana poiana requested review from Andreagit97 and Issif June 4, 2024 15:12
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Andreagit97, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,Issif,alacuku]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5af9aab into falcosecurity:main Jun 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants