Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collectors): uniform log level for partialOblectMetadata #87

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Dec 4, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area broker

/area protocol-buffers

/grafana-dashboard

/area collectors

/area tests

/area examples

What this PR does / why we need it:

Avoid logging each time a resource is deleted. Set log level to 3.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Dec 4, 2023

@alacuku: The label(s) area/collectors cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area broker

/area protocol-buffers

/grafana-dashboard

/area collectors

/area tests

/area examples

What this PR does / why we need it:

Avoid logging each time a resource is deleted. Set log level to 3.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leogr
Copy link
Member

leogr commented Dec 5, 2023

/lgtm

cc @FedeDP I think @poiana is not configured properly for this repo. It requires an explicit lgtm. Any idea?

@poiana poiana added the lgtm label Dec 5, 2023
@poiana
Copy link

poiana commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 982c40a into falcosecurity:main Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants