Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kernel_crawler): fixed photonOS configs generation for flavors too. #186

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Oct 20, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area crawler

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@maxgio92
Copy link
Member

/cc

@poiana poiana requested a review from maxgio92 October 20, 2023 08:24
maxgio92
maxgio92 previously approved these changes Oct 20, 2023
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 20, 2023

/hold

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 20, 2023

/unhold

Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 1e9122a into main Oct 20, 2023
5 checks passed
@poiana poiana deleted the chore/fix_photon_configs branch October 20, 2023 09:16
@FedeDP FedeDP restored the chore/fix_photon_configs branch October 23, 2023 13:42
@FedeDP FedeDP deleted the chore/fix_photon_configs branch October 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants