Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kernel_crawler): fix photonOS kernelrelease, stripping ".$arch" substring #190

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Oct 25, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area crawler

What this PR does / why we need it:

PhotonOS kernel packages have a ".$arch" suffix, thus our kernelrelease is different from uname -r output.
Fix this by manually removing the suffix.
Example:

  • uname -r -> 6.1.53-1.ph5
  • kernelrelease -> 6.1.53-1.ph5.x86_64

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 25, 2023

/cc @zuc @maxgio92

@poiana poiana requested review from maxgio92 and zuc October 25, 2023 13:32
@poiana poiana added the size/XS label Oct 25, 2023
@poiana poiana added the lgtm label Oct 25, 2023
@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 25, 2023

Example output now:

X86_64:
{
      "kernelversion": "1",
      "kernelrelease": "6.1.45-6.ph5",
      "target": "photon",
      "headers": [
        "https://packages.vmware.com/photon/5.0/photon_5.0_x86_64/x86_64/linux-secure-devel-6.1.45-6.ph5.x86_64.rpm"
      ]
}

aarch64:
{
      "kernelversion": "1",
      "kernelrelease": "6.1.56-6.ph5",
      "target": "photon",
      "headers": [
        "https://packages.vmware.com/photon/5.0/photon_updates_5.0_aarch64/aarch64/linux-devel-6.1.56-6.ph5.aarch64.rpm"
      ]
}

@poiana poiana merged commit 03ac9c3 into main Oct 25, 2023
5 checks passed
@poiana poiana deleted the fix/photon_kernelrelease branch October 25, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants