fix(kernel_crawler): fixed bottlerocket crawler. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
FedeDP
commented
May 22, 2024
| @@ -90,52 +90,74 @@ def get_package_tree(self, version=''): | |||
| self.checkout_version(v) | |||
|
|
|||
| # Find supported kernels dynamically | |||
| supported_kernel_specs = self.match_file("kernel-.*.spec", False) | |||
| supported_kernel_specs = self.match_file("kernel-.*.spec", True) | |||
There was a problem hiding this comment.
Fetch the full path to kernel specs, so that we can use their dirname as working dir when looking up for config file and supported flavors.
This is a fix.
|
/hold |
Signed-off-by: Federico Di Pierro <[email protected]>
|
/unhold |
leogr
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area crawler
What this PR does / why we need it:
As reported here: https://kubernetes.slack.com/archives/CMWH3EH32/p1716319428261609.
Latest bottlerocket release (1.20.0) broke our crawler because of: bottlerocket-os/bottlerocket#3897, bottlerocket-os/bottlerocket#3932, bottlerocket-os/bottlerocket#3905.
Basically, we expected flavored kernel configuration but they now only use a common one.
Adjusted the code to deal with this in a backward compatible manner.
Also, the
1.20.0kernel config will still be emitted with the1_1.20.0-$flavorkernel version string, so that we keep backward compatibility with existing driver loader logic (and we don't need to touch it neither); this means that as soon as this PR is merged and we start build drivers for the new bottlerocket, existing Falco will be able to download the new drivers.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: