Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release 0.18.1 #2082

Merged
merged 2 commits into from
Sep 25, 2024
Merged

sync: release 0.18.1 #2082

merged 2 commits into from
Sep 25, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 25, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks #2081 from master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP and others added 2 commits September 25, 2024 13:09
Signed-off-by: Luca Guerra <[email protected]>
Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
Co-authored-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 25, 2024

/milestone 0.18.1

@poiana poiana added this to the 0.18.1 milestone Sep 25, 2024
@poiana poiana added the size/XS label Sep 25, 2024
@poiana
Copy link
Contributor

poiana commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

     5.32%     +1.33%  [.] sinsp_evt::get_type
     4.41%     +0.75%  [.] sinsp_parser::process_event
     1.35%     -0.73%  [.] sinsp_parser::parse_context_switch
     5.12%     +0.72%  [.] next
     1.67%     -0.58%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
    10.60%     -0.49%  [.] sinsp_parser::reset
     4.09%     -0.43%  [.] sinsp_thread_manager::get_thread_ref
     1.21%     -0.40%  [.] sinsp_utils::find_longest_matching_evt_param
     0.65%     +0.37%  [.] sinsp_evt::get_param
     2.48%     +0.35%  [.] sinsp_thread_manager::find_thread

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0160         -0.0160           149           147           149           147
BM_sinsp_split_median                                          -0.0189         -0.0189           149           147           149           147
BM_sinsp_split_stddev                                          +0.8589         +0.8596             1             2             1             2
BM_sinsp_split_cv                                              +0.8892         +0.8899             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0566         +0.0566            44            46            44            46
BM_sinsp_concatenate_paths_relative_path_median                +0.0490         +0.0490            44            46            44            46
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8464         -0.8465             2             0             2             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8546         -0.8548             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0544         -0.0544            18            17            18            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0605         -0.0605            18            17            18            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4393         -0.4393             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4070         -0.4070             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0958         +0.0958            45            49            45            49
BM_sinsp_concatenate_paths_absolute_path_median                +0.0879         +0.0879            45            49            45            49
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.9706         +0.9698             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.7983         +0.7977             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0133         -0.0133           350           346           350           346
BM_sinsp_split_container_image_median                          -0.0148         -0.0148           350           345           350           345
BM_sinsp_split_container_image_stddev                          +4.7329         +4.7170             1             6             1             6
BM_sinsp_split_container_image_cv                              +4.8102         +4.7942             0             0             0             0

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.18.x@d4efc80). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/0.18.x    #2082   +/-   ##
=================================================
  Coverage                  ?   73.58%           
=================================================
  Files                     ?      253           
  Lines                     ?    31869           
  Branches                  ?     5640           
=================================================
  Hits                      ?    23452           
  Misses                    ?     8394           
  Partials                  ?       23           
Flag Coverage Δ
libsinsp 73.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 25, 2024

We reverted the required checks in test-infra (removing the zig jobs) to let the CI merge this PR: falcosecurity/test-infra#1637

@poiana poiana merged commit e1999d0 into release/0.18.x Sep 25, 2024
47 checks passed
@poiana poiana deleted the sync/018x branch September 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants